-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AprilTag pose estimation #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* stop using scuffed AdvantageKit Twist2d way
rutmanz
reviewed
Jan 30, 2024
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVision.java
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVisionIOLimelight.java
Outdated
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/util/vision/TimestampedVisionPose.java
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVision.java
Outdated
Show resolved
Hide resolved
rutmanz
reviewed
Jan 30, 2024
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVision.java
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVision.java
Outdated
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVision.java
Outdated
Show resolved
Hide resolved
src/main/java/org/team1540/robot2024/subsystems/vision/AprilTagVisionIO.java
Outdated
Show resolved
Hide resolved
* we can now change the code to filter out input from a single camera if the elevator is moving, instead of all cameras
rutmanz
reviewed
Feb 1, 2024
rutmanz
approved these changes
Feb 1, 2024
mimizh2418
added a commit
that referenced
this pull request
Feb 3, 2024
* feat: use waitForAll to get timesynced signals * fix: make swerve offset units consistent, swerve offsets happen in the same place * feat: use fused CANCoder for swerve turn position * bump: Phoenix 6 version * fix: import CAN_BUS constant correctly * fix: use Rotation2d factory methods * feat: refresh all signals at the same time (scuffed implementation?) * feat: use pigeon instead of navx * fix: potentially less scuffed signal refresher * fix+feat: signal refresher no longer static, better periodic updating, and error checking * fix: don't print stack traces to declutter logs * refactor: rename phoenixTimeSyncSignalRefresher to odometrySignalRefresher * AprilTag pose estimation (#18) * feat: use SwerveDrivePoseEstimator for odometry tracking * stop using scuffed AdvantageKit Twist2d way * feat: AprilTag vision IO and implementation for Limelight * feat: AprilTagVision subsystem * feat: fuse vision poses with drivetrain poses * fix: null vision poses no longer causing issues * fix: actually fix null vision poses * feat: limelight positioning adjusts based on elevator height * fix: properly update rear camera tag poses * feat: block vision updates with moving elevator * fix: correctly pass in suppliers * im dumb lol * fix: use optionals for getting vision pose * feat: change how vision pose accepter is used * we can now change the code to filter out input from a single camera if the elevator is moving, instead of all cameras * feat: untested vision sim io with photonvision sim support * fix: use vision pose in sim * fix: sim values as constants * refactor: remove unnecessary IO input * refactor: april tag layout declared in sim io instead of constants * fix: correctly check robot rotational velocity * fix: no duplicate constants --------- Co-authored-by: Zach Rutman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwerveDrivePoseEstimator